Re: [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage

From: Junio C Hamano <junkio@cox.net>
Date: 2006-09-24 06:46:59
Jakub Narebski <jnareb@gmail.com> writes:

> Junio C Hamano wrote:
>
>> -             "<a href=\"http://www.kernel.org/pub/software/scm/git/docs/\" title=\"git documentation\">" .
>> +             "<a href=\"" . esc_html($githelp_url) .
>> +             "\" title=\"" . esc_html($githelp_label) .
>> +             "\">" .
>
> Why not use $cgi->a_begin({-href=>esc_param($githelp_url), -title=>$githelp_label});
> or just plain $cgi->a and $cgi->img?

Be my guest and send in a proper patch please.

I was merely demonstrating my preference on how definition of
default values and actual use of them are separated.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Sep 24 06:47:14 2006

This archive was generated by hypermail 2.1.8 : 2006-09-24 06:48:23 EST