Junio C Hamano <junkio@cox.net> wrote: > Matthias Lederhofer <matled@gmx.net> writes: > > > Currently it is possible to give any string ending with a number as > > page. -1 for example is quite bad (error log shows probably 100 > > warnings). > > > > @@ -259,7 +259,7 @@ if (defined $hash_parent_base) { > > > > our $page = $cgi->param('pg'); > > if (defined $page) { > > - if ($page =~ m/[^0-9]$/) { > > + if ($page =~ m/[^0-9]/) { > > die_error(undef, "Invalid page parameter"); > > } > > } > > Are we complaining if $page is not a validly formatted number > here? If so why not > > unless ($page =~ /^\d+$/ && 1 <= $page) { > barf(...); > } The first page seems to have number 0. After removing the 1 <= $page this code should do the same as my patch, apply whatever you think is easier to read (I prefer if over unless most of the time). - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Mon Sep 18 07:38:43 2006
This archive was generated by hypermail 2.1.8 : 2006-09-18 07:39:25 EST