duplicate memory allocation in buildin-add.c

From: Liu Yubao <yubao.liu@gmail.com>
Date: 2006-09-15 21:26:55
http://www.kernel.org/git/?p=git/git.git;a=commitdiff;h=0d78153952e70c21e94dc6b7eefcb2ac5337a902

buildin-add.c:

+static void fill_directory(struct dir_struct *dir, const char **pathspec)
+{
+ 	const char *path, *base;
+ 	int baselen;
...
+ 	if (baselen) {
+ 		char *common = xmalloc(baselen + 1);
+ 		common = xmalloc(baselen + 1);
+ 		memcpy(common, *pathspec, baselen);
+ 		common[baselen] = 0;
+ 		path = base = common;
+ 	}
...

Allocate memory twice for "common" variable, is it indended? I'm very confused @_@
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Sep 15 21:28:45 2006

This archive was generated by hypermail 2.1.8 : 2006-09-15 21:29:29 EST