Re: [PATCH 2/4] git-archive: wire up TAR format.

From: Junio C Hamano <>
Date: 2006-09-09 07:42:13
Rene Scharfe <> writes:

> I did not sign off this exact patch.  I wrote and submitted the
> builtin-tar-tree.c part, with memory leak and all, then sent a note
> on where the leak needs to be plugged.  You put it together and
> converted it to struct archiver_args.  I'd very much have liked to
> see a comment stating this.  Or simply just say "based on code by
> Rene" or something.  The same is true for patch 3/4.

Thanks for clarification -- I also was wondering if you two were
working as a team exchanging drafts and the message I saw was
the fruit of such collaboration (like the way Johannes/Alex team
worked on C rewrite of merge-recursive).  Otherwise the sign-off
was indeed inappropriate.

>> +/*
>> + *
>> + */
> Especially I would not have signed off this invisible comment. ;)

I take your response is a mild NAK.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at
Received on Sat Sep 09 07:41:54 2006

This archive was generated by hypermail 2.1.8 : 2006-09-09 07:45:42 EST