Re: [PATCH] Trace into open fd and refactor tracing code.

From: Linus Torvalds <torvalds@osdl.org>
Date: 2006-09-01 07:14:26
On Thu, 31 Aug 2006, Christian Couder wrote:
>
> It's now possible to run the tests like this:
> 
> 	GIT_TRACE=9 make test 9>/var/tmp/trace.log

Wouldn't it me _much_ more natural to instead do

	GIT_TRACE=/var/tmp/trace.log make test

and just have git open that file with "O_APPEND | O_CREAT"?

Maybe make the rule be that this only happens if the GIT_TRACE variable 
starts with a '/' character (ie you have to make it an absolute path).

That way, if you want to do the fd thing, you can always just do

	GIT_TRACE=/proc/self/fd/9 make test 9>/var/tmp/trace.log

although I really don't know how well that works across a fork/exec that 
may or may not be closing the file descriptor (I think it's much simpler 
and more obvious to just give the filename directly).

Hmm?

			Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Sep 01 07:15:22 2006

This archive was generated by hypermail 2.1.8 : 2006-09-01 07:16:08 EST