Le dim 27 août 2006 08:12, Junio C Hamano a écrit : > Pierre Habouzit <madcoder@debian.org> writes: > > Allow a form of virtualhosting, when %h format is used. > > > > Signed-off-by: Pierre Habouzit <madcoder@debian.org> > > --- > > > > This is intended to be a more flexible solution, that also > > gives virtual hosting as a bonus. > > Nicely done, almost. > > Having to have the distinction between %p and %P formats feels > somewhat unwieldy, though. Not that I have a better suggestion. > > > +int is_base_path_fmt; > > +int is_user_path_fmt; > > I prefer these to be of type "static int". omg, how did I missed that. > Although I am not an authority of variable naming, these sound > funny to me. "is_XXX()" as a function name feels natural, > "is_XXX" as a variable name does not --- it is not clear what > the predicate is talking about. > > Maybe "use_fmt_for_base_path" is easier to understand? I dunno. > Or "user_path_is_fmt"? That's more logical but still somewhat > feels funny. agreed. There is also a second patch that never made it to the list that fixes: * some indentation problems due to a bad vimrc * --default-hostname switch (to handle virtual hosts even with older clients) * possible overflow in the formatting method. I'll recompute a new patch that superseeds that one, and merge your comments and my never sent patch too. -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This archive was generated by hypermail 2.1.8 : 2006-08-27 20:29:29 EST