Re: [PATCH 00/19] gitweb: Remove dependency on external diff and need for temporary files

From: Linus Torvalds <>
Date: 2006-08-27 13:30:49
On Fri, 25 Aug 2006, Jakub Narebski wrote:
> This series of patches (now finished) removes dependency on
> external diff (/usr/bin/diff) to produce commitdiff and blobdiff
> views, and the need for temporary files.

Ok, can we now please fix my final annouyance, which is that gitweb from 
the very beginning has apparently believed that the "Signed-off-by:" etc 
lines are not important, and they get stripped away when looking at the 

Also, "commit-diff" really should have some minimal authorship 
information. It's silly to have to go to "commit" and then separately ask 
for "diff" to see all these very basic things.

So I think that "commit-diff" should basically show the equivalent of "git 
show --pretty", ie author, date, commit message (including sign-offs) and 
then the diff.


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at
Received on Sun Aug 27 13:31:31 2006

This archive was generated by hypermail 2.1.8 : 2006-08-27 13:32:07 EST