Re: [PATCH] Fix a comparison bug in diff-delta.c

From: Pierre Habouzit <madcoder@debian.org>
Date: 2006-08-24 00:31:10
Le mer 23 août 2006 15:45, Johannes Schindelin a écrit :
> Hi,
>
> On Wed, 23 Aug 2006, Pierre Habouzit wrote:
> > -	for (i = 4; (1 << i) < hsize && i < 31; i++);
> > +	for (i = 4; (1u << i) < hsize && i < 31; i++);
>
> The variable i never takes on the value 31 (or any higher value), so
> there is no bug here. Unless you port git to a system where an int
> has less than 32 bit.

that remains quite tasteless though, and maybe that patch can be 
integrated to the "cleanup" series I sent later today.
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Received on Thu Aug 24 00:31:52 2006

This archive was generated by hypermail 2.1.8 : 2006-08-24 00:32:28 EST