Re: [PATCH] Fix a comparison bug in diff-delta.c

From: Nicolas Pitre <>
Date: 2006-08-23 13:17:24
On Wed, 23 Aug 2006, Pierre Habouzit wrote:

> (1 << i) < hspace is compared in the `int` space rather that in the unsigned one.
> the result will be wrong if hspace is between  0x40000000 and 0x80000000.
> Signed-off-by: Pierre Habouzit <>

Could you use (1u << i) instead of (unsigned)(1 << i) ?  That looks 
prettier to me at least.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at
Received on Wed Aug 23 13:18:04 2006

This archive was generated by hypermail 2.1.8 : 2006-08-23 13:18:42 EST