Re: [PATCH] git-mv: succeed even if source is a prefix of destination

From: Fredrik Kuivinen <freku045@student.liu.se>
Date: 2006-08-16 15:49:44
On Wed, Aug 16, 2006 at 02:20:32AM +0200, Johannes Schindelin wrote:
> 
> As noted by Fredrik Kuivinen, without this patch, git-mv fails on
> 
> 	git-mv README README-renamed
> 
> because "README" is a prefix of "README-renamed".
> 

Thank you. 'git-mv README README-renamed' works for me too now.

However, there still seems to be some minor problem with git-mv.

    $ git mv t t
    fatal: renaming t failed: Invalid argument
    $ git mv t t/
    fatal: renaming t failed: Invalid argument
    $ git mv t/ t/
    fatal: cannot move directory over file, source=t/, destination=t/
    $ git mv t/ t 
    fatal: cannot move directory over file, source=t/, destination=t/

I kind of expected to get 'can not move directory into itself' in all
of those cases. At least the same error messages should be given in
all cases.

It looks like we need some kind of path normalization before we do
those tests.

- Fredrik
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Aug 16 15:50:28 2006

This archive was generated by hypermail 2.1.8 : 2006-08-16 15:51:16 EST