Re: [PATCH 00/28] clean-ups of static functions and returns

From: Junio C Hamano <junkio@cox.net>
Date: 2006-08-15 11:54:34
"trajce nedev" <trajcenedev@hotmail.com> writes:

> So you're just going to continue passing numbers around in the hope
> that someday they'll be used for something?
>
> Trajce Nedev

It is more like "fearing someday we might modify the callees and
they may start returning error codes".

Admittedly, "someday" has a tendency not to come, but making the
callees void and changing the callers who are already checking
the error codes to ignore what are returned from them somehow
feel backwards and pushing that someday further into the future.

Either patches to implement the error checking in the callees,
or arguments that particular callees the series touch do not
have reasonably graceful error return path are welcome (the
former advocating against and the latter advocating for the
application of the patch).  


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Aug 15 11:57:09 2006

This archive was generated by hypermail 2.1.8 : 2006-08-15 11:58:23 EST