Re: [PATCH] gitweb: Different colours for tags and heads

From: Junio C Hamano <junkio@cox.net>
Date: 2006-08-12 10:58:54
Jakub Narebski <jnareb@gmail.com> writes:

> But they can be put into anonymous arrayref (e.g. ['heads/next',
> 'heads/autoconf'] at the start of 'autoconf' branch, or ['heads/master',
> 'heads/next', 'tags/v1.4.2'], not 'heads/master:heads/next:tags/v1.4.2'
> my patch did.

Concatenating them with ':' into a single string, only to later
split it, sounds simply stupid; I'd go for arrayref if I were
you.

> By the way, is it really usefull to have shortened ref name, e.g. 'web' for
> 'jn/web'? That is what gitweb does currently (only without giving ling name
> at all). It is probably bad practice, but I've had branches ab/sth and
> zz/sth, with the same shortname.

I think most people tend to use unique refs, so maybe showing
the shortname by default and unique suffix when ambiguous (that
would end up always showing minimal unique suffix) would be
reasonable.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sat Aug 12 10:59:48 2006

This archive was generated by hypermail 2.1.8 : 2006-08-12 11:00:28 EST