Hi, On Wed, 9 Aug 2006, Junio C Hamano wrote: > + > + /* NUL terminate the result */ > + if (desc.alloc <= desc.size) { > + desc.buffer = xrealloc(desc.buffer, desc.size + 1); > + desc.alloc++; While in this particular case, desc.alloc cannot be smaller than desc.size (and therefore the condition in the if() is misleading), it might be better to write "desc.alloc = desc.size + 1;" for others to understand... Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Thu Aug 10 17:48:09 2006
This archive was generated by hypermail 2.1.8 : 2006-08-10 17:50:14 EST