Re: [PATCH] Fix crash when GIT_DIR is invalid

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date: 2006-08-05 08:42:27
Hi,

On Fri, 4 Aug 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >  	bad_dir_environ:
> > -		if (!nongit_ok) {
> > +		if (nongit_ok) {
> >  			*nongit_ok = 1;
> 
> *BLUSH*  How could I have missed something like this...

It's too easy. I actually reviewed that patch, saw that I did the same 
(not!), and hit the bug...

Ciao,
Dscho "errare humanum est" --

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sat Aug 05 08:43:03 2006

This archive was generated by hypermail 2.1.8 : 2006-08-05 08:43:40 EST