Re: What's in git.git

From: carbonated beverage <ramune@net-ronin.org>
Date: 2006-08-03 19:31:13
Okay, dug around a bit more, and I admit, I'm not very familiar with Tk
(just started reading about it when poking at the gitk weirdness).

After applying your patch, rm'ing ~/.gitk, *and* doing:

--- gitk        2006-08-03 02:27:20.000000000 -0700
+++ /home/barbeque/bin/gitk     2006-08-03 02:24:52.000000000 -0700
@@ -429,7 +429,7 @@
     panedwindow .ctop -orient vertical
     if {[info exists geometry(width)]} {
        .ctop conf -width $geometry(width) -height $geometry(height)
-       set texth [expr {$geometry(height) - $geometry(canvh) - 56}]
+       set texth [expr {$geometry(height) - $geometry(canvh) - 136}]
        set geometry(ctexth) [expr {($texth - 8) /
                                    [font metrics $textfont -linespace]}]
     }

Then subsequent launches of gitk appear to be correct.  However, if the stale
~/.gitk is still around, the bug stays around.

Since my eyes are getting fuzzy, can someone that knows TCL/Tk eyeball that
and see if it's the actual cause, or just papering over a bug?

Thanks!

-- DN
Daniel
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Aug 03 19:31:52 2006

This archive was generated by hypermail 2.1.8 : 2006-08-03 19:32:29 EST