Hi, On Sun, 30 Jul 2006, Matthias Lederhofer wrote: > Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > > Why? The three users of cmd_log_walk() need to call setup_pager() > > explicitely, when cmd_log_walk() can do it for them? > > The explanation is below the commit message: > "setup_pager has to be called before git_diff_ui_config because the > latter uses pager_use_color initialized by setup_pager." > > > Oh, and I do not really understand why you would enable color _at all_ if > > you want to disable it when paging. Do you have many instances when you > > want a color diff which is short enough not to be paged? > When I use a pager that escapes the escape character or highlights the > content itself the output of git diff without the pager should have > colors but not with the pager. For example using git diff with a > pathspec is quite short most of the time. For git diff I have to > enable paging manually and run git diff | $PAGER usually but git log > uses the pager automatically and should not use colors with it. I understand now. Maybe you want to put such reasoning into the commit message next time? Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Sun Jul 30 19:34:09 2006
This archive was generated by hypermail 2.1.8 : 2006-07-30 19:34:37 EST