Re: [PATCH] tar-tree: add the "tar.applyUmask" config option

Willy Tarreau wrote:
> +int git_tar_config(const char *var, const char *value)
> +{
> +	if (!strcmp(var, "tar.umask")) {
> +		if (!strcmp(value, "user")) {
> +			tar_umask = umask(0);
> +			umask(tar_umask);
> +		} else {
> +			tar_umask = git_config_int(var, value);

Looks like you forgot:
    			umask(tar_umask);

> +		}
> +		return 0;
> +	}
> +	return git_default_config(var, value);
> +}

Or else move it to just before the "return 0;" line.

Rogan
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html