On Fri, 2006-07-14 at 11:23 -0700, Junio C Hamano wrote: > Josh Triplett <josht@us.ibm.com> writes: > > >> While I understand what you said about imap-send, I really would > >> feel better if this was optional. Do not change the default > >> output format, please. > > > > So rather than the --no-thread option provided in the second patch of > > this series, you'd prefer a --thread option to enable setting the > > In-Reply-To/References headers? > > Eh, that's not what I meant. > > I do not mind the code you added to log-tree.c and revision.h, > and honestly I do not care which of threading or non-threading > mode is the default, although I think your explanation that it > parallels what send-email does makes a lot of sense. > > But I do mind that the code added by the first patch to > cmd_format_patch runs by default, and worse yet, there is no > option turn it off. Setting message_id and ref_message_id in > rev_info struct should be something the end user should ask for > explicitly by invoking the command with an option, perhaps > --with-message-id, which you probably would also want to turn on > when any of --no-thread, --thread or --initial-reply-to options > are given. How would that work though? Threading requires a Message-Id on at least the first message, so to avoid Message-IDs by default would require turning off threading by default; I can do that if you like, but you suggested that you didn't mind having threading as the default. I could, however, avoid generating Message-Id on the subsequent messages, and avoid generating that Message-Id if you give --no-thread. Would that work? - Josh Triplett - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Sat Jul 15 05:21:06 2006
This archive was generated by hypermail 2.1.8 : 2006-07-15 05:21:34 EST