Re: remove perl from git-commit.sh

From: Junio C Hamano <junkio@cox.net>
Date: 2006-07-13 14:38:56
"Alex Riesen" <raa.lkml@gmail.com> writes:

> It is really annoying when the essentials do not work.
> I think we could improve at  least them, by minimizing
> their dependencies to external tools.
>
> ---
>
> git-commit.sh has only ohne place where perl is used
> and it can actually quite trivially be done in sh.
> git-ls-files without "-z" produces quoted output, even if
> is different from that produced by perl code it could be
> enough. Otherwise I'd better suggest to add another
> quoting style (replacing only \t, \n and backslash) than
> having to constantly patch git-commit.sh for binmode
> or perl path (Windows has no stable tool set, and perl
> for instance often resides "somewhere").

(1) Sign-off?

(2) I think the cover letter comment talks more apporpirate
    things than your proposed commit message.  The commit log is
    not a place to vent your frustration.  It's where you
    justify why that change was needed for people who will want
    to figure out why your patch broke their workflow later.

I do not think anybody parses git-status output to figure out
the list of paths that are touched/untracked/etc., so I am not
opposed to this change itself.



-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Jul 13 14:39:38 2006

This archive was generated by hypermail 2.1.8 : 2006-07-13 14:40:42 EST