Re: [PATCH] Fix linking for not-so-clever linkers.

From: Linus Torvalds <torvalds@osdl.org>
Date: 2006-07-11 07:34:42
On Mon, 10 Jul 2006, Junio C Hamano wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On one of my systems, the linker is not intelligent enough to link with
> > pager.o (in libgit.a) when only the variable pager_in_use is needed. The
> > consequence is that the linker complains about an undefined
> > variable.
> 
> I do not understand this quite yet -- which executable is your
> linker building when it does this?
> 
> Maybe we need ranlib?

Shouldn't be needed, since we use "$(AR) rcs", where that "s" should do 
the equivalent of the old-fashioned "ranlib" call.

However, that said, I think Johannes' patch is worth applying regardless, 
since it's kind of sad to link in pager.o just because of a variable that 
ends up never mattering (ie any program that uses "diff.c" but isn't 
built-in).

Of course, once/if everything is built-in, this doesn't matter, but in the 
meantime this isn't the first time we've re-organized things so that you 
don't have to link in files that you don't need. After all, that was the 
whole reason environment.c ended up existing in the first place..

			Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Jul 11 07:36:07 2006

This archive was generated by hypermail 2.1.8 : 2006-07-11 07:36:34 EST