Re: [PATCH 1/3] Add read_cache_from() and discard_cache()

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Okay. After reading the comment, I am quite certain we can just set the 
> index_file_timestamp to 0.

Thanks.

> So, I still think that these two lines should be in the cleanup part of 
> get_merge_bases().

I think that is sane -- please make it so.

> BTW personally, I prefer the one-function approach, i.e. a flag which says 
> if it is okay not to clean up.

Yup. Agreed.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html