Matthias Kestenholz <lists@spinlock.ch> writes: > * Geoff Russell (geoffrey.russell@gmail.com) wrote: >> It appears to have got lost when the shell script got converted to C. >> > Yes, this was intentional. You should sign off your changes while > committing (git commit -s|--signoff) When should one commit _without_ signoff? The obvious answer is: when one doesn't approve of the changes in the commit... But in my usual workflow, commit means works-for-me-I-think-it-is-good. :-) Also, here's a trivial patch to the git-format-patch doc. I recently had the same confusion trying to get git-format-patch to add signoff for me... Remove reference to signoff option (-s) in git-format-patch Signed-off-by: Seth Falcon <sethfalcon@gmail.com> --- Documentation/git-format-patch.txt | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt index 7cc7faf..d13f463 100644 --- a/Documentation/git-format-patch.txt +++ b/Documentation/git-format-patch.txt @@ -9,7 +9,7 @@ git-format-patch - Prepare patches for e SYNOPSIS -------- [verse] -'git-format-patch' [-n | -k] [-o <dir> | --stdout] [--attach] [-s] [-c] +'git-format-patch' [-n | -k] [-o <dir> | --stdout] [--attach] [-c] [--diff-options] <his> [<mine>] DESCRIPTION @@ -44,10 +44,6 @@ OPTIONS Do not strip/add '[PATCH]' from the first line of the commit log message. --s|--signoff:: - Add `Signed-off-by:` line to the commit message, using - the committer identity of yourself. - -c|--check:: Display suspicious lines in the patch. The definition of 'suspicious lines' is currently the lines that has -- 1.3.3.gb931 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Wed May 31 23:58:41 2006
This archive was generated by hypermail 2.1.8 : 2006-05-31 23:59:26 EST