Re: [PATCH 1/2] Handle branch names with slashes

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: 2006-05-18 01:18:49
On 16/05/06, Karl Hasselström <kha@treskal.com> wrote:
> On 2006-05-15 23:48:04 -0700, Junio C Hamano wrote:
>
> > Karl Hasselström <kha@treskal.com> writes:
> >
> > > I had to change the patch@branch/top command-line syntax to
> > > patch@branch%top, in order to get sane parsing. The /top variant
> > > is still available for repositories that have no slashy branches;
> > > it is disabled as soon as there exists at least one subdirectory
> > > of refs/heads. Preferably, this compatibility hack can be killed
> > > some time in the future.
> >
> > I wonder if using double-slashes is an easier alternative to type
> > than '%', like "patch@branch//top". That way, you do not have to
> > forbid per-cent sign in branch names.
>
> Good argument. And // does look slightly better than %, too. But I'll
> wait a few days this time, or else someone will surely come along with
> an even better idea. :-)

I also thing // is a better solution than %.

There is another option, a bit more complicated, "patch@branch:top".
This would imply replacing : with .. in the current handling of the -r
option in diff/mail/export but it would make the commit or patch
ranges look more like GIT's arguments.

-- 
Catalin
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu May 18 01:19:25 2006

This archive was generated by hypermail 2.1.8 : 2006-05-18 01:19:45 EST