Re: RFC: New diff-delta.c implementation

From: Junio C Hamano <junkio@cox.net>
Date: 2006-04-23 03:57:17
Geert Bosch <bosch@adacore.com> writes:

> That's about how I implemented it in my last patch.
> Is it correct that 0 means that there is no max_size?
> Should I set *delta_size to 0 when doing an early
> return, or leave it alone?

When failing, I think
the convention is to return NULL and what you do with *delta_size
does not matter, but Nico and pack-objects.c code can answer
that better than I can ;-).

> Note that this really is a micro-optimization,

True.  max_size is a hint, and the caller validates the size
independently anyway, so ignoring is fine.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Apr 23 03:57:51 2006

This archive was generated by hypermail 2.1.8 : 2006-04-23 03:58:12 EST