[RESEND] [PATCH] fix gitk with lots of tags

From: Jim Radford <radford@blackbean.org>
Date: 2006-04-19 04:06:14
Hi Junio,

I've gotten no reposnse from Paul on this patch[1].  If it seems ok to
you, would you mind putting it in your queue for him?  I hate to see
gitk die with "argument list too long" messages.  They're so 640k.

Thanks,
-Jim

[1] Maybe he judges people by the color of their IP address?
    Then again, he could just be busy.

---

This fix allow gitk to be used on repositories with lots of tags.  It
bypasses git-rev-parse and passes its arguments to git-rev-list
directly to avoid tcl's argument list length restrictions.

Signed-Off-By: Jim Radford <radford@blackbean.org>

diff --git a/gitk b/gitk
index 26fa79a..40672fb 100755
--- a/gitk
+++ b/gitk
@@ -17,19 +17,11 @@ proc gitdir {} {
 }
 
 proc parse_args {rargs} {
-    global parsed_args
-
-    if {[catch {
-	set parse_args [concat --default HEAD $rargs]
-	set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
-    }]} {
-	# if git-rev-parse failed for some reason...
-	if {$rargs == {}} {
-	    set rargs HEAD
-	}
-	set parsed_args $rargs
+    if {$rargs == {}} {
+        return HEAD
+    } else {
+	return $rargs
     }
-    return $parsed_args
 }
 
 proc start_rev_list {rlargs} {
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Apr 19 04:07:18 2006

This archive was generated by hypermail 2.1.8 : 2006-04-19 04:07:41 EST