Re: [PATCH] git log [diff-tree options]...

From: Timo Hirvonen <tihirvon@gmail.com>
Date: 2006-04-10 08:22:58
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> +static int cmd_whatchanged(int argc, const char **argv, char **envp)
> +{
> +	memmove(argv + 2, argv + 1, argc - 1);

Shouldn't the size be sizeof(char *) * argc (NULL terminated array)?
There's also overflow...

-- 
http://onion.dynserv.net/~timo/
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Apr 10 08:23:23 2006

This archive was generated by hypermail 2.1.8 : 2006-04-10 08:23:37 EST