Re: [PATCH 2/2] pack-objects: be incredibly anal about stdio semantics

From: Junio C Hamano <junkio@cox.net>
Date: 2006-04-03 07:09:02
Linus Torvalds <torvalds@osdl.org> writes:

> This is the "letter of the law" version of using fgets() properly in the
> face of incredibly broken stdio implementations.  We can work around the
> Solaris breakage with SA_RESTART, but in case anybody else is ever that
> stupid, here's the "safe" (read: "insanely anal") way to use fgets.

Thanks.

It's good that I can say "Oh, I think this is the part that is
broken, but I am going to bed" to find the problem solved by
capable others when I wake up the next day.  Global distributed
development process at the finest, although I suspect Jason,
Linus and myself are all in the same timezone ;-)

Did you mean this as a real change or a demonstration?  The
sigaction change is a real fix, but somehow I find this one
similar to the "(void*) NULL" thing you objected earlier (which
was not merged because I agreed with your argument)...

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Apr 03 07:09:58 2006

This archive was generated by hypermail 2.1.8 : 2006-04-03 07:10:20 EST