Re: Solaris cloning woes partly diagnosed

From: Linus Torvalds <torvalds@osdl.org>
Date: 2006-04-03 05:22:01
On Sun, 2 Apr 2006, Jason Riedy wrote:

> And Linus Torvalds writes:
>  - 
>  - I'd be willing to bet that it's the fact that we take signals.
> 
> Unfortunately, I'm too busy to check into this, but I've
> run into similar problems in the past.  Just takes a busy 
> file server.
> 
>  - We do, for example, expect that regular file writing not do that. At least 
>  - "write_sha1_from_fd()" will just do a "write()" without testing the error 
>  - return, [...]
> 
> There is an xwrite in git-compat-util.h...

Well, git itself is actually fairly good about these things. Right now I'm 
seriously suspecting Solaris stdio as being just horribly impolite.

git tends to not just use xwrite() in most places, but check the return 
value for partial sizes etc. I tried to grep for places where we were 
lazy, and there really seems to be just a very small handful, and they 
shouldn't impact this case at all (you have to have a seriously broken 
setup for them to matter, but we should fix them nonetheless.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Apr 03 05:22:38 2006

This archive was generated by hypermail 2.1.8 : 2006-04-03 05:22:54 EST