Re: [PATCH] xdiff: Show function names in hunk headers.

From: Junio C Hamano <junkio@cox.net>
Date: 2006-03-28 16:54:25
Mark Wooding <mdw@distorted.org.uk> writes:

> The function names are parsed by a particularly stupid algorithm at the
> moment: it just tries to find a line in the `old' file, from before the
> start of the hunk, whose first character looks plausible.  Still, it's
> most definitely a start.

> +		    (isalpha((unsigned char)*rec) || /* identifier? */
> +		     *rec == '_' ||	/* also identifier? */
> +		     *rec == '(' ||	/* lisp defun? */
> +		     *rec == '#')) {	/* #define? */

GNU diff -p does "^[[:alpha:]$_]"; personally I think any line
that does not begin with a whitespace is good enough.  In either
way, your patch is good.  Thanks.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Mar 28 16:55:00 2006

This archive was generated by hypermail 2.1.8 : 2006-03-28 16:55:16 EST