Re: [PATCH] Fix for rpm creation

From: Petr Baudis <pasky@suse.cz>
Date: 2006-02-17 02:43:20
Dear diary, on Thu, Feb 16, 2006 at 04:33:44PM CET, I got a letter
where Josef Weidendorfer <Josef.Weidendorfer@gmx.de> said that...
> 
> Signed-off-by: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
> 
> ---
> This fixes "make rpm", which currently gives at the very end:
> ...
> Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/cogito-0.17rc2.GIT-1-root-weidendo
> error: Installed (but unpackaged) file(s) found:
>    /usr/share/cogito/default-exclude

Thanks, applied.

> Another thing:
> "cg-switch origin" currently refuses to switch to the branch.
> Wouldn't it be better to handle this like "cg-seek origin"?

Well, it depends on what you expect this to actually do. If you really
want to just seek to whichever is the current origin commit, that's very
different from what cg-switch does - you want cg-seek and cg-switch
doing the same thing when it does something totally different from the
user POV otherwise would be very confusing.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Of the 3 great composers Mozart tells us what it's like to be human,
Beethoven tells us what it's like to be Beethoven and Bach tells us
what it's like to be the universe.  -- Douglas Adams
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Feb 17 02:43:00 2006

This archive was generated by hypermail 2.1.8 : 2006-02-17 02:43:11 EST