Hi, apart from my thinking this is not backward-compatible (you are supposed to be able to pull from a complete repo, even if it has a non-shallow-capable upload-pack), here are my comments: - it is good that MAXPARENT and struct commit_graft are in more public places now. - reparse_* is misleading. Nothing is reparsed, but rather "unparsed". - I'd hesitate to let git-daemon write temporary files. That is a whole new can of security worms. - It looks wrong to me to define MAX_PARENTS as 20 in upload-pack.c, when MAXPARENT is defined as 16 in cache.h. - The custom_graft issue could be handled in a more elegant manner if git was lib'ified (no temporary file). Since that is already the plan, why not do that first, and come back later? Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Wed Feb 01 00:59:00 2006
This archive was generated by hypermail 2.1.8 : 2006-02-01 00:59:09 EST