On Sun, 29 Jan 2006, Junio C Hamano wrote: > I do not have objections to git-tar-tree changes, but I am > hesitant to use the tree parser in diff-tree due to its memory > retention behaviour. We already use the commit parser in > diff-tree but I think we currently do not ask for the tree part > of the object to be parsed. I suspect this patch would badly > interact with long-running "diff-tree --stdin", which is the > workhorse of whatchanged. I haven't benched it though, and I'd > be happy to see the impact is proven to be negligible. I'll look into discarding the struct trees after use (since we're not keeping flags on them, or storing references to them long-term), so we can use the same parser without worse memory behavior. It does seem to take a bunch more memory (and, oddly, be very slow) as I currently have it. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Mon Jan 30 09:04:16 2006
This archive was generated by hypermail 2.1.8 : 2006-01-30 09:04:25 EST