Catalin Marinas wrote: > On 11/01/06, Chuck Lever <cel@citi.umich.edu> wrote: > >>Chuck Lever wrote: >> >>>seems to me the "git clone" script should create an environment where >>>"git-rev-parse --git-dir" ought to work correctly. >> >>stgit/main.py does a special stack.Series('master') just for the clone >>command. it really shouldn't do this -- the crt_series.init() in the >>clone command ought to be fixed to do this properly. > > > If the stack.Series() doesn't get a parameter, it will try to get the > default branch using 'git-symbolic-ref HEAD'. Any command run outside > a tree (and which doesn't have the -h option) would fail. The clone > command is the only one allowed to run outside a tree and that's why I > passed a default branch name. This is to avoid the creation of another > stack.Series() object later when the git tree was cloned. > > See the attached patch for a different fix and let me know if there > are any issues with it. I should probably release 0.8.1 with the fixed > bugs. looked at the patch. that's what i had in mind. the extra exception processing in Series.__init__ is a nice touch. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This archive was generated by hypermail 2.1.8 : 2006-01-13 01:52:00 EST