Re: [PATCH 2/3] ls-files --others --directory: give trailing slash

From: Linus Torvalds <torvalds@osdl.org>
Date: 2006-01-08 10:35:08
On Sat, 7 Jan 2006, Junio C Hamano wrote:
> 
>  * Likes, dislikes?  This suits better for *my* purpose of
>    calling this from git-status, but it might be undesirable for
>    your Porcelain.

Likes.

However, I'd re-write it as just

	memcpy(fullname + baselen + len, "/", 2);
	len++;
	if (show_other_directories &&
	    !dir_exists(fullname, baselen + len))
		break;
	read_directory(fullname, fullname, baselen + len);

because let's face it, every user wants the "+1", so just do it once 
up-front instead of adding one in three different places.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Jan 08 10:35:57 2006

This archive was generated by hypermail 2.1.8 : 2006-01-08 10:36:07 EST