On Wed, Dec 14, 2005 at 01:30:16PM -0800, Junio C Hamano wrote: > Good point but "|| exit" would be more appropriate. With the > above patch, I suspect "make check" merely stops at the first > error but resulting return code would still be zero, wouldn't > it? Yes, here is a patch that uses exit instead of break. --- Do not let errors pass by unnoticed when running `make check'. Signed-off-by: Amos Waterland <apw@us.ibm.com> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) bc721e2d99487c0240514a848ac1cb84c086e008 diff --git a/Makefile b/Makefile index 01b6643..d494ad4 100644 --- a/Makefile +++ b/Makefile @@ -449,7 +449,7 @@ test-delta$X: test-delta.c diff-delta.o $(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $^ check: - for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i; done + for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done -- 0.99.9.GIT - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Thu Dec 15 08:45:05 2005
This archive was generated by hypermail 2.1.8 : 2005-12-15 08:45:11 EST