Re: [PATCH 5/11] git-applypatch: Usage string clean-up, emit usage string at incorrect invocation

From: Timo Hirvonen <tihirvon@gmail.com>
Date: 2005-12-14 23:45:42
On Tue, 13 Dec 2005 21:20:57 -0800
Junio C Hamano <junkio@cox.net> wrote:

> freku045@student.liu.se writes:
> 
> >  . git-sh-setup
> >  
> > +[[ "$#" = "3" || "$#" = "4" ]] || usage
> > +
> 
> I do not see much advantage to use [[...]] construct here.

[[ ]] is bashishm. Does not work with ash.


test $# -ge 3 && test $# -le 4 || usage

You don't need to quote $# because it is always defined (and always
non-negative integer).  You can't unset or set it.

-- 
http://onion.dynserv.net/~timo/
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Dec 14 23:46:35 2005

This archive was generated by hypermail 2.1.8 : 2005-12-14 23:46:42 EST