The only case that I can think of that this patch may make a difference in behaviour in a valid repository is the HEAD pointer that points at nowhere (i.e. refs/heads/master) immediately after git-init-db, so in that sense this change may be safe for most purposes. However, we might want to write a tool to iterate over what we have under .git/refs/ and warn about them to help the user fix broken branches/tags, and do_for_each_ref() dying like this would not help that usage. Not that the current loop is any better for that purpose. We silently ignore not just dangling ref and ref not storing 40-byte hex, but files starting with a period '.', names longer than 255 bytes, and unreadable ones, all of which we would probably want to warn about in such a tool. -jc - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Fri Oct 28 05:04:04 2005
This archive was generated by hypermail 2.1.8 : 2005-10-28 05:04:08 EST