Re: [PATCH] Make fetch-pack play nicer with servers which do not speak multi_ack

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> But you are right.  If you made 20 commits on top of my "master"
>> branch head, we should send those 20 (and the commit you based
>> on your changes, which the other end has), way before sending
>> the ancient v0.99 tag.  Probably, we should never be sending
>> v0.99 tag as "have" if we are going to send your "master" branch
>> head, since the commit that tag refers to is reachable by your
>> "master" branch head but there are a lot more commit between
>> them, some of which will give us better "common" selected, and
>> that v0.99 tag is what the other end said they have so is known
>> to be ACKed if sent.
>
> You.AN4re right. Complete common refs are sent even if they are ancestors of 
> other complete common refs. I.AN4ll think about that.

I just realized that I have two refs you would rather send the
last while fetching from me most of the time: junio-gpg-pub tag
and todo head.  If you manage to get acked either by non multi
aware remote before saying "have" on anything on the main
branch, I think you would get *everything* back --- which is
quite bad.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html