Re: [PATCH] Added -d and -e options to the "git" script.

A Large Angry SCM <gitzilla@gmail.com> writes:

> David Kågedal wrote:
>> These flags override the GIT_DIR and EDITOR environment variables.
>>
> [Patch snipped]
>
> An option for GIT_DIR maybe since it's a Git environment variable but a 
> command line option to change the EDITOR _environment_ variable is NOT 
> appropriate for git.

Yeah, I should have separated those two so that the GIT_DIR option
could be accepted on its own.  And it should maybe have a --git-dir=
log form as well.

The reason I did -e too was simply that I needed it for the same
reason I needed -d.  I wanted to run git with specific values for
GIT_DIR and EDITOR without having to setenv them in emacs.  But the
EDITOR trick I'm using is a hack and should be replaced anyway. (I use
EDITOR=cat to get access to the default commit message with comments
from 'git commit').

So please disregard the -e part of my patch for now.  You are free to
disregard the -d part as well, but I think that makes some kind of
sense.

And If we go down this path, maybe flags for other GIT_* environment
variables should be settable with git command line flags too?

-- 
David Kågedal

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html