[PATCH] fix git-checkout-cache segfault on parisc

From: James Bottomley <James.Bottomley@SteelEye.com>
Date: 2005-08-14 01:29:32
This one I think is Linus' fault, so send him a brown paper bag with my
complements ...

The index cleanup code is executed via atexit() which is *after* main
has completed, so the stack allocated cache_file has gone out of scope.
Parisc seems to use stack in the destructor functions, so cache_file
gets partially overwritten leading to the predictable disastrous
consequences.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

---

James

diff --git a/checkout-cache.c b/checkout-cache.c
--- a/checkout-cache.c
+++ b/checkout-cache.c
@@ -80,10 +80,11 @@ static int checkout_all(void)
 static const char checkout_cache_usage[] =
 "git-checkout-cache [-u] [-q] [-a] [-f] [-n] [--prefix=<string>] [--] <file>...";
 
+static struct cache_file cache_file;
+
 int main(int argc, char **argv)
 {
 	int i, force_filename = 0;
-	struct cache_file cache_file;
 	int newfd = -1;
 
 	if (read_cache() < 0) {
diff --git a/index.c b/index.c


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Aug 14 01:33:46 2005

This archive was generated by hypermail 2.1.8 : 2005-08-14 01:33:48 EST