>Another dependency :-( I can live without http-pull but not >without commit-tree. Yes, the extra dependency sucks ... libcurl is missing from one of the systems that I'd like to use GIT on ... so I'd prefer a solution that doesn't involve libcurl. >What's wrong with the patch I sent to fix this: > > http://marc.theaimsgroup.com/?m=111446501003389 > I missed it ... there is a problem that you drop the timezone. When I used this patch, I ended up with a commit that said: author Keith Owens <kaos@sgi.com> 1114239900 committer Tony Luck <tony.luck@intel.com> 1114832076 -0700 See the missing timezone on the author line :-) This is most upsetting to cg-log. It prints "expr: syntax error" and then author Keith Owens <kaos@sgi.com> Thu, 01 Jan 1970 00:00:01 >> + /* find the timezone at the end */ >> + p = date + strlen(date); >> + while (p > date && isdigit(*--p)) >> + ; >> + if ((*p == '+' || *p == '-') && strlen(p) == 5) >> + snprintf(result, maxlen, "%lu %5.5s", then, p); > >This will choke on dates from Linus which have a trailing comment: > > Date: Fri, 29 Apr 2005 15:26:14 -0700 (PDT) You are right ... that's what comes from only looking at one e-mail message to determine that pattern to match :-) I'd much rather see your version fixed up to preserve the timezone than have the libcurl dependency. -Tony - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Sat Apr 30 13:46:03 2005
This archive was generated by hypermail 2.1.8 : 2005-04-30 13:46:03 EST