On Sun, 2005-04-24 at 01:38 +0200, Petr Baudis wrote: > Dear diary, on Fri, Apr 22, 2005 at 09:06:43PM CEST, I got a letter > where Martin Schlemmer <azarah@nosferatu.za.org> told me that... > > @@ -311,6 +296,17 @@ > > if (!pw) > > die("You don't exist. Go away!"); > > realgecos = pw->pw_gecos; > > + /* > > + * The GECOS fields are seperated via ',' on Linux, FreeBSD, etc, > > + * and ';' on AIX. > > + */ > > +#if defined(__aix__) > > + if (strchr(realgecos, ';')) > > + *strchr(realgecos, ';') = 0; > > +#else > > + if (strchr(realgecos, ',')) > > + *strchr(realgecos, ',') = 0; > > +#endif > > len = strlen(pw->pw_name); > > memcpy(realemail, pw->pw_name, len); > > realemail[len] = '@'; > > I'm confused, what does this has to do with AIX? Do we even have / can > expect to have any major AIX users? > Given. > I'm not too happy with this, I have to say. It seems it won't do always > the right thing anyway. I would still favour the approach when you cut > off everything after ';', and everything after ',' if no ';' is found. > Seems simplest, safest, etc. > > Tell me about anyone who has a semicolon in his realname. > Point I guess is still that the only valid delimiter on linux is ',', and the only reason for the ';' was because of some aix/whatever user saying that is a delimiter as well. But like I said: cat $this > /dev/null ... This is basically the same type of discussion as the hash collision one, and I'm sure we all have better things to do. Thanks, -- Martin Schlemmer - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This archive was generated by hypermail 2.1.8 : 2005-04-24 09:45:46 EST