Re: [patch] fixup GECOS handling

From: David Woodhouse <dwmw2@infradead.org>
Date: 2005-04-18 22:35:12
On Mon, 2005-04-18 at 12:36 +0200, Martin Schlemmer wrote:
> realgecos[strchr(realgecos, ',') - realgecos] = '\0';

Er, *strchr(realgecos, ',') = 0; surely? Even if the compiler is clever
enough to optimise out the gratuitous addition and subtraction, that's
no real excuse for it.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Apr 18 22:35:47 2005

This archive was generated by hypermail 2.1.8 : 2005-04-18 22:35:47 EST